Use crypto/rand.Read instead of deprecated math/rand.Read #16459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Blair <mail@jamesblair.net>
serathius
approved these changes
Aug 22, 2023
ahrtr
approved these changes
Aug 22, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated to golang 1.20. This golang release deprecated
math/rand.Seed(which in most cases can now be removed) andmath/rand.Readin favor ofcrypto/rand.Read, refer: https://go.dev/doc/go1.20In #16447 we removed instances of
math/rand.Seed.After scanning through the codebase this pull request updates the one instance I could find of us using
math/rand.Readand replaces it withcrypto/rand.Read.